Differential D16256

[Scheduler] Reuse fileinfo from FilteredDirIterator
ClosedPublic
Actions

Authored by bruns on Oct 16 2018, 5:52 PM.

Details

Reviewers
poboiko
ngraham
Group Reviewers
Baloo
Frameworks
Commits
R293:19e9edaec570: [Scheduler] Reuse fileinfo from FilteredDirIterator
Summary

The FilteredDirIterator already builds a QFileInfo for every returned
path, just reuse it instead of constructing another one.

Test Plan

make
no functional changes

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Oct 16 2018, 5:52 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptOct 16 2018, 5:52 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Oct 16 2018, 5:52 PM
ngraham accepted this revision.Oct 17 2018, 1:46 AM
This revision is now accepted and ready to land.Oct 17 2018, 1:46 AM
Closed by commit R293:19e9edaec570: [Scheduler] Reuse fileinfo from FilteredDirIterator (authored by bruns). · Explain WhyOct 17 2018, 1:47 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 43773

View Options

src/file/filtereddiriterator.h

Loading...
View Options

src/file/filtereddiriterator.cpp

Loading...
View Options

src/file/unindexedfileiterator.cpp

Loading...