Differential D1623

[client] Don't delete windows from PlasmaWindowModel
ClosedPublic
Actions

Authored by graesslin on May 17 2016, 7:43 AM.

Details

Reviewers
hein
Group Reviewers
Plasma
Commits
R127:5ad723ac8edc: [client] Don't delete windows from PlasmaWindowModel
Summary

So far when the PlasmaWindowManagement went down the PlasmaWindowModel
deleted all windows. This is not needed as the PlasmaWindow has the
PlasmaWindowManagement as parent, so it will be destroyed anyway.

The delete in PlasmaWindowModel risks that other signals connecting
to the same signal will operate on deleted data, which they did not
expect. So it's better to not delete here and let the later auto
delete handle it.

Diff Detail

Repository
R127 KWayland
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 3833.May 17 2016, 7:43 AM
graesslin retitled this revision from to [client] Don't delete windows from PlasmaWindowModel.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: Plasma, hein.
Restricted Application added a project: Plasma. · View Herald TranscriptMay 17 2016, 7:43 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
hein accepted this revision.May 17 2016, 9:44 AM
hein edited edge metadata.
This revision is now accepted and ready to land.May 17 2016, 9:44 AM
Closed by commit R127:5ad723ac8edc: [client] Don't delete windows from PlasmaWindowModel (authored by graesslin). · Explain WhyMay 17 2016, 11:13 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/client/plasmawindowmodel.cpp (1 line)

Diff 3838

View Options

src/client/plasmawindowmodel.cpp

Loading...