[wayland] Make the "Lower Window" shortcut work with transients
AbandonedPublic

Authored by zzag on Oct 15 2018, 6:19 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Summary

Currently, the "Lower Window" shortcut doesn't have any effect when applying
it to a transient because we lower the transient in the unconstrained stacking
order and then we "raise" it back when building the constrained stacking order.

If we lower a transient, make sure that main clients are lowered too.

Test Plan
  • Assigned a shortcut to "Lower Window" in System Settings;
  • Opened Konsole;
  • Opened Kate and its preferences window;
  • Pressed the shortcut.

Diff Detail

Repository
R108 KWin
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 4508
Build 4526: arc lint + arc unit
zzag created this revision.Oct 15 2018, 6:19 PM
Restricted Application added a project: KWin. · View Herald TranscriptOct 15 2018, 6:19 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Oct 15 2018, 6:19 PM
zzag edited the summary of this revision. (Show Details)Oct 15 2018, 6:23 PM
zzag added a comment.EditedOct 15 2018, 6:46 PM

The only corner case is when the parent is active. In such a case, one would need to press the shortcut several times.

zzag updated this revision to Diff 43743.Oct 16 2018, 4:14 PM

Rebase.

davidedmundson accepted this revision.Oct 31 2018, 3:58 PM
This revision is now accepted and ready to land.Oct 31 2018, 3:58 PM
zzag updated this revision to Diff 44579.Oct 31 2018, 9:05 PM

Use allMainClients

zzag updated this revision to Diff 44763.Nov 3 2018, 12:07 PM
Add another test
zzag abandoned this revision.Jan 31 2019, 9:41 PM