Differential D16215

Cleanup: Merge all code from main.cpp into unit test tstestapp.cpp
ClosedPublic
Actions

Authored by gregormi on Oct 15 2018, 1:21 AM.

Details

Reviewers
dhaumann
Group Reviewers
Kate
Commits
R40:5009ec07d044: Cleanup: Merge all code from main.cpp into unit test tstestapp.cpp
Summary

Also improve the documentation

Diff Detail

Repository
R40 Kate
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
gregormi created this revision.Oct 15 2018, 1:21 AM
Restricted Application added a project: Kate. · View Herald TranscriptOct 15 2018, 1:21 AM
Restricted Application added a subscriber: kwrite-devel. · View Herald Transcript
gregormi requested review of this revision.Oct 15 2018, 1:21 AM
dhaumann accepted this revision.Oct 15 2018, 7:32 PM
dhaumann added a subscriber: dhaumann.

The title "Cleanup" is a bit too generic imho. Better eould be something along the lines "Ceanup: Merge main() into unit test tsttestapp.cpp" along with a detailed description :) Maybe something for future commits? Good enough this time, but for commits in KDE Frameworks this would not be good enough, since "Cleanup" would then end up in David's changelog, which is too generic (cleanup of what?).

Please push.

This revision is now accepted and ready to land.Oct 15 2018, 7:32 PM
gregormi retitled this revision from Cleanup to Cleanup: Merge all code from main.cpp into unit test tstestapp.cpp.Oct 15 2018, 7:47 PM
gregormi edited the summary of this revision. (Show Details)
Closed by commit R40:5009ec07d044: Cleanup: Merge all code from main.cpp into unit test tstestapp.cpp (authored by gregormi). · Explain WhyOct 15 2018, 9:20 PM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 5 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Path
No data available.

Diff 43691