Cleanup: Merge all code from main.cpp into unit test tstestapp.cpp
ClosedPublic

Authored by gregormi on Oct 15 2018, 1:21 AM.

Details

Summary

Also improve the documentation

Diff Detail

Repository
R40 Kate
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3887
Build 3905: arc lint + arc unit
gregormi created this revision.Oct 15 2018, 1:21 AM
Restricted Application added a project: Kate. · View Herald TranscriptOct 15 2018, 1:21 AM
Restricted Application added a subscriber: kwrite-devel. · View Herald Transcript
gregormi requested review of this revision.Oct 15 2018, 1:21 AM
dhaumann accepted this revision.Oct 15 2018, 7:32 PM
dhaumann added a subscriber: dhaumann.

The title "Cleanup" is a bit too generic imho. Better eould be something along the lines "Ceanup: Merge main() into unit test tsttestapp.cpp" along with a detailed description :) Maybe something for future commits? Good enough this time, but for commits in KDE Frameworks this would not be good enough, since "Cleanup" would then end up in David's changelog, which is too generic (cleanup of what?).

Please push.

This revision is now accepted and ready to land.Oct 15 2018, 7:32 PM
gregormi retitled this revision from Cleanup to Cleanup: Merge all code from main.cpp into unit test tstestapp.cpp.Oct 15 2018, 7:47 PM
gregormi edited the summary of this revision. (Show Details)
This revision was automatically updated to reflect the committed changes.