pretty vital (at least for me) if one doesn't have compositing.
we can't use the normal QPalette::Inactive because of color schemes,
but I made the new scrollbar color code follow the same dimming colors.
hindenburg |
Konsole |
pretty vital (at least for me) if one doesn't have compositing.
we can't use the normal QPalette::Inactive because of color schemes,
but I made the new scrollbar color code follow the same dimming colors.
tested with and without compositing, with and without scrollbar,
and dark and light color schemes.
Lint Skipped |
Unit Tests Skipped |
I think this also fixes the colors when changing system colors (I don't think the new scrollbar color code works well with 568095c482785903148130fe72ee3d45f325c453).
occured to me that this might be useful for e. g. split views as well, so not only dimming when the window loses focus. should I change it to just check for widget focus?
KWin has itself this feature for all windows, i've use it, this can be helpful on split view, did you test it with KWin effect enabled to verify that it does not look strange/incorrect?
yeah, this is more when I can't use KWin or another compositor. I tested with a compositor now, and even with it turned on it didn't look as bad as I feared (not too dark, still readable).
started using it on my system, and noticed that some colors didn't get dimmed, and those are the ones that aren't normal terminal colors from the color scheme... so instead just use a simpler solution by drawing a semi-transparent black rect on top.