Differential D16182

Port KWordQuiz away from deprecated API and kdelibs4support
ClosedPublic
Actions

Authored by yurchor on Oct 13 2018, 5:56 PM.

Details

Reviewers

None

Group Reviewers

KDE Edu

Commits

R338:a6e61818e3e8: Port KWordQuiz away from deprecated API and kdelibs4support

Summary

Porting by examples. Files for KFilterProxySearchLine replacement are shamelessly borrowed from KDevelop. Code to recover files is borrowed from Umbrello.

Test Plan

Start KWordQuiz and open an example (e.g. /usr/share/kwordquiz/examples/us_states_and_capitals.kvtml or src/examples/us_states_and_capitals.kvtml in the source tree).
Try to print it into the cards PDF file (KWordQuiz tab under "Options" should work).
Try to link image (Vocabulary -> Link Image) or sound (Vocabulary -> Link Sound) with a cell.
Try to filter the list with entering "co" in the filter proxy list at the top of the window.
Try if everything works (saves and restores) in the "Settings -> Configure KWordQuiz" window (1st and 2nd tabs).

Diff Detail

Repository

R338 KWordQuiz

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

yurchor created this revision.Oct 13 2018, 5:56 PM

Restricted Application added a project: KDE Edu. · View Herald TranscriptOct 13 2018, 5:56 PM

Restricted Application added a subscriber: kde-edu. · View Herald Transcript

yurchor requested review of this revision.Oct 13 2018, 5:56 PM

It appears that it is pretty normal that print preview shows nothing on a system with no default printer with QPrintPreviewDialog. So the porting is done correctly here.

aacid added a subscriber: aacid.Oct 15 2018, 9:29 PM

aacid added inline comments.

src/kwordquiz.h
252	Confused about this one, that's in kitemviews and thus needs no porting, no? https://api.kde.org/frameworks/kitemviews/html/classKFilterProxySearchLine.html

yurchor marked an inline comment as done.Oct 16 2018, 4:52 AM

yurchor added inline comments.

src/kwordquiz.h
252	From the referred page: Deprecated: since 5.50, use QLineEdit directly. If filtering is expensive, consider a short timer to not act on every keypress, and if results are large, consider not reacting until 3 letters.

yurchor retitled this revision from Port KWordQuiz away from kdelibs4support to Port KWordQuiz away from deprecated API and kdelibs4support.Oct 16 2018, 2:35 PM

Fix print preview.

yurchor edited the summary of this revision. (Show Details)Oct 17 2018, 5:46 PM

Add missing files. Sorry.

Code looks reasonable, i *have not* tried it.

So maybe wait for someone to actually give it a second review or if you're totally confident you're not breaking stuff just commit it

In D16182#344997, @aacid wrote:

Code looks reasonable, i *have not* tried it.

So maybe wait for someone to actually give it a second review or if you're totally confident you're not breaking stuff just commit it

Sure. I will wait for two weeks from now then commit the changes if no one objects.

This revision was not accepted when it landed; it landed in state Needs Review.Nov 1 2018, 3:57 PM

Closed by commit R338:a6e61818e3e8: Port KWordQuiz away from deprecated API and kdelibs4support (authored by yurchor). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		CMakeLists.txt (2 lines)
M		src/CMakeLists.txt (3 lines)
M		src/cleardialogbase.ui (10 lines)
A	M	src/filterproxysearchline.h (49 lines)
A	M	src/filterproxysearchline.cpp (58 lines)
M		src/kwordquiz.h (5 lines)
M		src/kwordquiz.cpp (32 lines)
M		src/kwqcardscene.cpp (2 lines)
M		src/kwqcleardialog.cpp (3 lines)
M		src/kwqtablemodel.cpp (3 lines)
M		src/kwqtableview.h (1 line)
M		src/kwqtableview.cpp (64 lines)
M		src/kwqtutor.cpp (12 lines)
M		src/preftutor.cpp (2 lines)
M		src/preftutorbase.ui (12 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	43547			Oct 13 2018, 5:16 PM	★	★
Diff 2	43807			Oct 17 2018, 5:43 PM	★	★
Diff 3	43808			Oct 17 2018, 5:53 PM	★	★
Diff 4	44646	94e2408	R338:a6e61818e3e8d9ed3aa2f4c16a98902319250673	Nov 1 2018, 3:56 PM	★	★