Differential D16164

Specifying http protocol when getting Open Sans font to fix Scripting API
ClosedPublic
Actions

Authored by luansimoes on Oct 12 2018, 6:54 PM.

Details

Reviewers
tcanabrava
Commits
R73:ba719a2b569f: Specifying http protocol when getting Open Sans font to fix Scripting API
Summary

Object QWebView, inside Scripting API, was not displaying any text. Specifying http protocol when getting Open Sans font fixes this problem and then the text is displayed properly.

Diff Detail

Repository
R73 Rocs
Branch
fixingScriptingApiText
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3850
Build 3868: arc lint + arc unit
luansimoes created this revision.Oct 12 2018, 6:54 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptOct 12 2018, 6:54 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
luansimoes requested review of this revision.Oct 12 2018, 6:54 PM
luansimoes edited the summary of this revision. (Show Details)Oct 12 2018, 6:56 PM
tcanabrava added a comment.Oct 13 2018, 9:12 AM

I don't like that. What happens if the person is not int he internet? can you remove that url completely and see if it works?
*if* it works, I'd rather remove the need to be on the internet.

pino added a subscriber: pino.Oct 13 2018, 9:23 AM
In D16164#342359, @tcanabrava wrote:

I don't like that. What happens if the person is not int he internet? can you remove that url completely and see if it works?
*if* it works, I'd rather remove the need to be on the internet.

In addition to this, please add a font fallback in case Open Sans is not available in the system -- DejaVu can be a choice, since it is available in all the distros (of course check that it looks OK).

luansimoes updated this revision to Diff 43561.Oct 13 2018, 9:38 PM

Using Dejavu Sans instead of downloading Open Sans font

tcanabrava requested changes to this revision.Oct 14 2018, 7:33 AM

Strings with spaces should be inside quotes., just like the Helvetica Neue is.

This revision now requires changes to proceed.Oct 14 2018, 7:33 AM
luansimoes updated this revision to Diff 43599.Oct 14 2018, 5:08 PM

Fixed syntax of font name

tcanabrava accepted this revision.Oct 15 2018, 8:32 AM
This revision is now accepted and ready to land.Oct 15 2018, 8:32 AM
Closed by commit R73:ba719a2b569f: Specifying http protocol when getting Open Sans font to fix Scripting API (authored by luansimoes, committed by tcanabrava). · Explain WhyOct 15 2018, 8:36 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 43561

View Options

src/plugins/scriptapi/html/bootstrap.css

Loading...