Changed the create code document feature to use the filename given by the user as a complement to the makesTabClosable commit.
Details
Details
Diff Detail
Diff Detail
- Repository
- R73 Rocs
- Branch
- fixingCreatedCodeFileName
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 3821 Build 3839: arc lint + arc unit
src/project/project.cpp | ||
---|---|---|
226 ↗ | (On Diff #43470) | QLatin1Char('/'), Those creates the data in copile time instead of runtime |
243–253 ↗ | (On Diff #43470) | the code for createCode and openCode document are the same, share the internal code. |
src/project/project.h | ||
94 ↗ | (On Diff #43470) | const QString& filePath, this way you don't create a copy of the variable just to pass it around. |
src/ui/mainwindow.cpp | ||
370 ↗ | (On Diff #43470) | QStringLiteral , but perhaps it's better to i18n("untitled") ? |
493 ↗ | (On Diff #43470) | QLatin1Char('/'), QStringLiteral(".js") |
494 ↗ | (On Diff #43470) | QFileInfo (cheaper than a QFile) |
src/ui/mainwindow.cpp | ||
---|---|---|
497 ↗ | (On Diff #43470) | just use the KMessageBox::error(...) factory to create an error message box with all the typical look and feel in KDE |
Comment Actions
Switched QString into QStringLiteral, QString into QLatin1Char and QMessageBox into KMessageBox.