Differential D16101

[activities] Fix logic error in user menu blocking activity updates
ClosedPublic
Actions

Authored by davidedmundson on Oct 10 2018, 12:56 PM.

Details

Reviewers
zzag
Group Reviewers
KWin
Commits
R108:273a3fabd0ee: [activities] Fix logic error in user menu blocking activity updates
Summary

There's an attempt to block updates to activities whilst the popup menu
is showing.

In one of the two code paths for positioning the menu the block is set
but instead of releasing the block at the end of the exec locks it
again.

CCBUG: 335725

Test Plan

On X11 changed activities with the popup menu near the bottom.
It still flickered like crazy whilst the menu is open (see bug report)
But now at least fixes itself after

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: KWin. · View Herald TranscriptOct 10 2018, 12:56 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
davidedmundson requested review of this revision.Oct 10 2018, 12:56 PM
zzag accepted this revision.Oct 10 2018, 1:41 PM
This revision is now accepted and ready to land.Oct 10 2018, 1:41 PM
Closed by commit R108:273a3fabd0ee: [activities] Fix logic error in user menu blocking activity updates (authored by davidedmundson). · Explain WhyOct 10 2018, 1:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Museractions.cpp (2 lines)

Diff 43305

View Options

useractions.cpp

Loading...