Use consistently Q_SIGNALS/Q_SLOTS (and set QT_NO_SIGNALS_SLOTS_KEYWORDS)
ClosedPublic
Actions

Authored by kossebau on May 13 2016, 3:56 PM.

Details

Reviewers

nienhueser
rahn

Commits

R34:399f91c15d01: Use consistently Q_SIGNALS/Q_SLOTS (and set QT_NO_SIGNALS_SLOTS_KEYWORDS)

Summary

Currently there is a mix of both signals/slots and Q_SIGNALS/Q_SLOTS.
Given Marble is also promoted as library, it seems to make sense to
standardize on Q_SIGNALS/Q_SLOTS, and for consistency do that project-wide,
not just for the lib API.
Adding QT_NO_SIGNALS_SLOTS_KEYWORDS should prevent any regressions here.

Test Plan

Still builds (WITH_KDE=ON & BUILD_MARBLE_EXAMPLES=ON) and marble app still
works.

Diff Detail

Repository

R34 Marble

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

kossebau updated this revision to Diff 3811.May 13 2016, 3:56 PM

kossebau retitled this revision from to Use consistently Q_SIGNALS/Q_SLOTS (and set QT_NO_SIGNALS_SLOTS_KEYWORDS).

kossebau updated this object.

kossebau edited the test plan for this revision. (Show Details)

kossebau added reviewers: rahn, nienhueser.

Looks good to me. I just hope it does not confuse newcomers if they find signals/slots keywords not to work if they work on new code.

This revision is now accepted and ready to land.May 14 2016, 6:26 AM

Closed by commit R34:399f91c15d01: Use consistently Q_SIGNALS/Q_SLOTS (and set QT_NO_SIGNALS_SLOTS_KEYWORDS) (authored by kossebau). · Explain WhyMay 14 2016, 10:51 AM

This revision was automatically updated to reflect the committed changes.

Large Diff

This large diff affects 124 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (6 lines)
M			examples/cpp/marbleQuick2/main.cpp (2 lines)
M			examples/cpp/vehicletracking/vehicletracking.h (8 lines)
M			src/apps/marble-kde/KdeMainWindow.h (2 lines)
M			src/apps/marble-maps/TextToSpeechClient.h (2 lines)
M			src/apps/marble-ui/ControlView.h (4 lines)
M			src/lib/marble/AddLinkDialog.h (2 lines)
M			src/lib/marble/EditPlacemarkDialog.h (6 lines)
M			src/lib/marble/FormattedTextWidget.h (4 lines)
M			src/lib/marble/MarbleAbstractPresenter.h (4 lines)
M			src/lib/marble/MarbleLegendBrowser.h (4 lines)
M			src/lib/marble/MarbleWidgetInputHandler.h (2 lines)
M			src/lib/marble/MovieCapture.h (6 lines)
M			src/lib/marble/MovieCaptureDialog.h (6 lines)
M			src/lib/marble/TourCaptureDialog.h (4 lines)
M			src/lib/marble/TreeViewDecoratorModel.h (2 lines)
M			src/lib/marble/cloudsync/CloudRouteModel.h (2 lines)
M			src/lib/marble/cloudsync/CloudRoutesDialog.h (6 lines)
M			src/lib/marble/cloudsync/ConflictDialog.h (6 lines)
M			src/lib/marble/cloudsync/MergeItem.h (2 lines)
M			src/lib/marble/cloudsync/OwncloudSyncBackend.h (4 lines)
M			src/lib/marble/cloudsync/RouteItemDelegate.h (2 lines)
M			src/lib/marble/cloudsync/RouteSyncManager.h (6 lines)
M			src/lib/marble/declarative/CloudSync.h (4 lines)
M			src/lib/marble/declarative/MarbleQuickItem.h (6 lines)
M			src/lib/marble/declarative/MarbleQuickItem.cpp (4 lines)
M			src/lib/marble/declarative/Navigation.h (2 lines)
M			src/lib/marble/declarative/Placemark.h (2 lines)
M			src/lib/marble/declarative/SearchBackend.h (4 lines)
M			src/lib/marble/kineticmodel.h (6 lines)
M			src/lib/marble/osm/OsmRelationEditorDialog.h (2 lines)
M			src/lib/marble/routing/RoutingProfileSettingsDialog.h (2 lines)
M			src/plasmoid/worldclock.h (6 lines)
M			src/plugins/positionprovider/geoclue/GeoCluePositionProviderPlugin.h (2 lines)
M			src/plugins/positionprovider/geoclue/GeoCute/PositionProvider.h (2 lines)
M			src/plugins/positionprovider/geoclue/GeoCute/Provider.h (2 lines)
M			src/plugins/positionprovider/geoclue/GeoCute/VelocityProvider.h (2 lines)
M			src/plugins/positionprovider/gpsd/GpsdConnection.h (4 lines)
M			src/plugins/positionprovider/gpsd/GpsdPositionProviderPlugin.h (2 lines)
M			src/plugins/positionprovider/gpsd/GpsdThread.h (2 lines)
M			src/plugins/render/annotate/AnnotatePlugin.h (4 lines)
M			src/plugins/render/annotate/EditGroundOverlayDialog.h (4 lines)
M			src/plugins/render/annotate/EditPolygonDialog.h (6 lines)
M			src/plugins/render/annotate/EditPolylineDialog.h (6 lines)
M			src/plugins/render/annotate/MergingPolygonNodesAnimation.h (6 lines)
M			src/plugins/render/annotate/MergingPolylineNodesAnimation.h (6 lines)
M			src/plugins/render/annotate/NodeItemDelegate.h (4 lines)
M			src/plugins/render/annotate/NodeModel.h (2 lines)
M			src/plugins/render/atmosphere/AtmospherePlugin.h (2 lines)
M			src/plugins/render/earthquake/EarthquakePlugin.h (4 lines)
M			src/plugins/render/elevationprofilefloatitem/ElevationProfileContextMenu.h (2 lines)
M			src/plugins/render/foursquare/FoursquareItem.h (2 lines)
M			src/plugins/render/gpsinfo/GpsInfo.h (2 lines)
M			src/plugins/render/license/License.h (2 lines)
M			src/plugins/render/measure/MeasureConfigDialog.h (4 lines)
M			src/plugins/render/navigation/ArrowDiscWidget.h (2 lines)
M			src/plugins/render/opencaching/OpenCachingItem.h (4 lines)
M			src/plugins/render/opencaching/OpenCachingPlugin.h (4 lines)
M			src/plugins/render/opencachingcom/OpenCachingComItem.h (4 lines)
M			src/plugins/render/opendesktop/OpenDesktopItem.h (2 lines)
M			src/plugins/render/overviewmap/OverviewMap.h (4 lines)
M			src/plugins/render/positionmarker/PositionMarker.h (2 lines)
M			src/plugins/render/speedometer/Speedometer.h (2 lines)
M			src/plugins/render/twitter/twitterPlugin.h (4 lines)
M			src/plugins/runner/gpx/tests/TestTrack.cpp (2 lines)
M			src/thumbnailer/thumbnailer.h (2 lines)
M			tests/AbstractDataPluginModelTest.cpp (2 lines)
M			tests/AbstractDataPluginTest.cpp (2 lines)
M			tests/AbstractFloatItemTest.cpp (2 lines)
M			tests/BillboardGraphicsItemTest.cpp (2 lines)
M			tests/BookmarkManagerTest.cpp (2 lines)
M			tests/FrameGraphicsItemTest.cpp (2 lines)
M			tests/GeoDataTreeModelTest.cpp (2 lines)
M			tests/GeoUriParserTest.cpp (2 lines)
M			tests/GnomonicProjectionTest.cpp (2 lines)
M			tests/LocaleTest.cpp (2 lines)
M			tests/MapViewWidgetTest.cpp (2 lines)
M			tests/MarbleMapTest.cpp (2 lines)
M			tests/MarbleRunnerManagerTest.cpp (2 lines)
M			tests/MarbleWidgetSpeedTest.cpp (2 lines)
M			tests/MarbleWidgetTest.cpp (2 lines)
M			tests/MercatorProjectionTest.cpp (2 lines)
M			tests/PlacemarkPositionProviderPluginTest.cpp (2 lines)
M			tests/PluginManagerTest.cpp (2 lines)
M			tests/QuaternionTest.cpp (2 lines)
M			tests/RenderPluginModelTest.cpp (2 lines)
M			tests/RenderPluginTest.cpp (2 lines)
M			tests/RouteRequestTest.cpp (2 lines)
M			tests/ScreenGraphicsItemTest.cpp (2 lines)
M			tests/StereographicProjectionTest.cpp (2 lines)
M			tests/TestBalloonStyle.cpp (2 lines)
M			tests/TestCamera.cpp (2 lines)
M			tests/TestEquality.cpp (2 lines)
M			tests/TestFeatureDetach.cpp (2 lines)
M			tests/TestGeoData.cpp (2 lines)
M			tests/TestGeoDataCoordinates.cpp (2 lines)
M			tests/TestGeoDataCopy.cpp (2 lines)
M			tests/TestGeoDataGeometry.cpp (2 lines)
M			tests/TestGeoDataLatLonAltBox.cpp (2 lines)
M			tests/TestGeoDataPack.cpp (2 lines)
M			tests/TestGeoDataTrack.cpp (2 lines)
M			tests/TestGeoDataWriter.cpp (2 lines)
M			tests/TestGeoPainter.cpp (2 lines)
M			tests/TestGeoSceneWriter.cpp (2 lines)
M			tests/TestGeometryDetach.cpp (2 lines)
M			tests/TestGroundOverlay.cpp (2 lines)
M			tests/TestGudermannian.cpp (2 lines)
M			tests/TestGxTimeSpan.cpp (2 lines)
M			tests/TestGxTimeStamp.cpp (2 lines)
M			tests/TestLatLonQuad.cpp (2 lines)
M			tests/TestListStyle.cpp (2 lines)
M			tests/TestModel.cpp (2 lines)
M			tests/TestNetworkLink.cpp (2 lines)
M			tests/TestOsmAnnotation.cpp (2 lines)
M			tests/TestTimeSpan.cpp (2 lines)
M			tests/TestTimeStamp.cpp (2 lines)
M			tests/TestToCircumscribedRectangle.cpp (2 lines)
M			tests/TestTour.cpp (2 lines)
M			tests/TileIdTest.cpp (2 lines)
M			tests/ViewportParamsTest.cpp (2 lines)
M			tools/mapreproject/NasaWorldWindToOpenStreetMapConverter.h (4 lines)
M			tools/mapreproject/OsmTileClusterRenderer.h (4 lines)
M			tools/mapreproject/Thread.h (4 lines)
M			tools/osm-sisyphus/region.h (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	3811	6a61fd9		May 13 2016, 3:56 PM	★	★
Diff 2	3815	6a61fd9	rMARBLE399f91c15d011a2cddfd44020b14f5aa7c33095e	May 14 2016, 10:51 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
05ef041fa4c8	3cfd8d8cc78b	6a61fd987b1a	Friedrich W. H. Kossebau	Use consistently Q_SIGNALS/Q_SLOTS (and set QT_NO_SIGNALS_SLOTS_KEYWORDS) (Show More…)	May 13 2016, 3:47 PM

Use consistently Q_SIGNALS/Q_SLOTS (and set QT_NO_SIGNALS_SLOTS_KEYWORDS)ClosedPublicActions

Details

Diff Detail

Large Diff

Revision ContentsChangeset List

Diff 3815

CMakeLists.txt

examples/cpp/marbleQuick2/main.cpp

examples/cpp/vehicletracking/vehicletracking.h

src/apps/marble-kde/KdeMainWindow.h

src/apps/marble-maps/TextToSpeechClient.h

src/apps/marble-ui/ControlView.h

src/lib/marble/AddLinkDialog.h

src/lib/marble/EditPlacemarkDialog.h

src/lib/marble/FormattedTextWidget.h

src/lib/marble/MarbleAbstractPresenter.h

src/lib/marble/MarbleLegendBrowser.h

src/lib/marble/MarbleWidgetInputHandler.h

src/lib/marble/MovieCapture.h

src/lib/marble/MovieCaptureDialog.h

src/lib/marble/TourCaptureDialog.h

src/lib/marble/TreeViewDecoratorModel.h

src/lib/marble/cloudsync/CloudRouteModel.h

src/lib/marble/cloudsync/CloudRoutesDialog.h

src/lib/marble/cloudsync/ConflictDialog.h

src/lib/marble/cloudsync/MergeItem.h

src/lib/marble/cloudsync/OwncloudSyncBackend.h

src/lib/marble/cloudsync/RouteItemDelegate.h

src/lib/marble/cloudsync/RouteSyncManager.h

src/lib/marble/declarative/CloudSync.h

src/lib/marble/declarative/MarbleQuickItem.h

src/lib/marble/declarative/MarbleQuickItem.cpp

src/lib/marble/declarative/Navigation.h

src/lib/marble/declarative/Placemark.h

src/lib/marble/declarative/SearchBackend.h

src/lib/marble/kineticmodel.h

src/lib/marble/osm/OsmRelationEditorDialog.h

src/lib/marble/routing/RoutingProfileSettingsDialog.h

src/plasmoid/worldclock.h

src/plugins/positionprovider/geoclue/GeoCluePositionProviderPlugin.h

src/plugins/positionprovider/geoclue/GeoCute/PositionProvider.h

src/plugins/positionprovider/geoclue/GeoCute/Provider.h

src/plugins/positionprovider/geoclue/GeoCute/VelocityProvider.h

src/plugins/positionprovider/gpsd/GpsdConnection.h

src/plugins/positionprovider/gpsd/GpsdPositionProviderPlugin.h

src/plugins/positionprovider/gpsd/GpsdThread.h

src/plugins/render/annotate/AnnotatePlugin.h

src/plugins/render/annotate/EditGroundOverlayDialog.h

src/plugins/render/annotate/EditPolygonDialog.h

src/plugins/render/annotate/EditPolylineDialog.h

src/plugins/render/annotate/MergingPolygonNodesAnimation.h

src/plugins/render/annotate/MergingPolylineNodesAnimation.h

src/plugins/render/annotate/NodeItemDelegate.h

src/plugins/render/annotate/NodeModel.h

src/plugins/render/atmosphere/AtmospherePlugin.h

src/plugins/render/earthquake/EarthquakePlugin.h

src/plugins/render/elevationprofilefloatitem/ElevationProfileContextMenu.h

src/plugins/render/foursquare/FoursquareItem.h

src/plugins/render/gpsinfo/GpsInfo.h

src/plugins/render/license/License.h

src/plugins/render/measure/MeasureConfigDialog.h

src/plugins/render/navigation/ArrowDiscWidget.h

src/plugins/render/opencaching/OpenCachingItem.h

src/plugins/render/opencaching/OpenCachingPlugin.h

src/plugins/render/opencachingcom/OpenCachingComItem.h

src/plugins/render/opendesktop/OpenDesktopItem.h

src/plugins/render/overviewmap/OverviewMap.h

src/plugins/render/positionmarker/PositionMarker.h

src/plugins/render/speedometer/Speedometer.h

src/plugins/render/twitter/twitterPlugin.h

src/plugins/runner/gpx/tests/TestTrack.cpp

src/thumbnailer/thumbnailer.h

tests/AbstractDataPluginModelTest.cpp

tests/AbstractDataPluginTest.cpp

tests/AbstractFloatItemTest.cpp

tests/BillboardGraphicsItemTest.cpp

tests/BookmarkManagerTest.cpp

tests/FrameGraphicsItemTest.cpp

tests/GeoDataTreeModelTest.cpp

tests/GeoUriParserTest.cpp

Use consistently Q_SIGNALS/Q_SLOTS (and set QT_NO_SIGNALS_SLOTS_KEYWORDS)
ClosedPublic
Actions

Revision Contents
Changeset List