This patch :
- fixes the export behavior on Windows by using the cmake GenerateExportHeader feature
- allows research and inclusion of mman.h/mman.lib
Details
Details
- Reviewers
kfunk - Group Reviewers
KDE Edu - Commits
- R332:7d9cbd6f96a6: Fix the compilation of kiten on Windows
Tested on windows/neon
Diff Detail
Diff Detail
- Repository
- R332 Kiten
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 3678 Build 3696: arc lint + arc unit
Comment Actions
ecm_mark_nongui_executable(kitengen) in CMake code has the same effect I think (and is the cleaner version)
| CMakeLists.txt | ||
|---|---|---|
| 41 | Here and below: endif() is sufficient | |
| 42 | Just: message(STATUS "Found mman-win32 include: ${MMAN_INCLUDE_PATH}") | |
| 49 | Dito, just on one line | |
| lib/CMakeLists.txt | ||
| 30 | No need for repetition if(WIN32)
target_link_libraries(kiten ${MMAN_LIBRARY})
endif()... below the platform agnostic target_link_libraries(...) works | |
Comment Actions
Feel free to push after fixing the last remark.
| CMakeLists.txt | ||
|---|---|---|
| 43 ↗ | (On Diff #43193) | Would rather do a target_include_directories(kiten PRIVATE ${MMAN_INCLUDE_PATH}) in e.g. line 28. This part here should only *detect* MMAN. |