Differential D16062

Add a blueprint for mman-win32 and dependency in kiten
ClosedPublic
Actions

Authored by sdepiets on Oct 9 2018, 8:20 AM.

Details

Reviewers
vonreth
Group Reviewers
Craft
Commits
R877:7657ba693f9b: Add a blueprint for mman-win32 and dependency in kiten

Diff Detail

Repository
R877 Craft Blueprints for KDE
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3679
Build 3697: arc lint + arc unit
sdepiets requested review of this revision.Oct 9 2018, 8:20 AM
sdepiets created this revision.
sdepiets added reviewers: Craft, vonreth.Oct 9 2018, 8:33 AM
sdepiets added projects: Windows, Craft.
vonreth added a comment.Oct 9 2018, 8:37 AM

so this is only needed for mingw?

sdepiets updated this revision to Diff 43198.Oct 9 2018, 8:39 AM

Fix description

vonreth accepted this revision.Oct 9 2018, 8:41 AM
This revision is now accepted and ready to land.Oct 9 2018, 8:41 AM
kfunk added a subscriber: kfunk.Oct 9 2018, 8:43 AM
kfunk added inline comments.
kde/applications/kiten/kiten.py
14

Note that there's also Qt API to emulate mmap(): http://blog.qt.io/blog/2007/10/15/file-mapping/

More work of course, to port to that, but also the future-proof version...

Just an idea; I won't have time to test Kiten after potential refactorings either...

vonreth added a comment.Oct 9 2018, 8:54 AM

Hm but Qt doesn't do mmap? When a rcc is loaded it reads the whole file to ram?

kfunk added a comment.Oct 9 2018, 9:08 AM
In D16062#339766, @vonreth wrote:

Hm but Qt doesn't do mmap? When a rcc is loaded it reads the whole file to ram?

Not sure what you mean, but I meant to prefer using QFileDevice::{map,unmap} in Kiten source code in order to *not* have to depend on an external library providing a mmap implementation...

sdepiets closed this revision.Oct 9 2018, 9:18 AM

Revision Contents
Changeset List

Diff 43198

View Options

kde/applications/kiten/kiten.py

Loading...
View Options

libs/_windows/mman/mman.py

Loading...