| leinir | |
| pino |
This adds a positional argument to peruse's command line, which accepts a file url, which will then be opened upon the opening of the mainwindow qml file.
Of course, the real reason we'd want this is that this also makes opening a file directly from Dolphin or other such sources possible :)
After building/applying patch, open a file like Peruse bla.cbz, or try opening via dolphin.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Also, please append the %f placeholder to the command in the Exec of the two .desktop files: this way, it will be possible to select peruse (and perusecreator) as application for opening the comics.
| src/app/main.cpp | ||
|---|---|---|
| 49 | no need to initialize it explicitly, just QString filename; is enough | |
| src/app/qml/PeruseMain.qml | ||
| 305 | unneeded change | |
| src/common/peruse_helpers.h | ||
| 11 | const & for "filename" | |
| src/creator/main.cpp | ||
| 43 | same as in peruse | |
| src/app/qml/PeruseMain.qml | ||
|---|---|---|
| 317 | Always was a bit worried that something like this might adversely affect the experience, since the scanner will be going in the background... have you noticed anything while working on this? | |
| src/app/qml/PeruseMain.qml | ||
|---|---|---|
| 317 | I haven't but then, that's also why I am not pushing it directly, because I am not sure what the consequences might be? | |
| src/app/qml/PeruseMain.qml | ||
|---|---|---|
| 317 | Really, the only consequence should be that it would be slow for the first while, until the scan is completed... If there are other side effects, then they would want fixing, because obviously, we don't want to postpone much later than this :) | |