Found by clazy.
- Group Reviewers
- R110:66a0c467dd51: Avoid creation of needless temporary containers
Nice findings, feel free to ignore the stylistic changes I commented, except the qDeleteAll one, and do unrelated further cleanup in a separate patch
I think we typically use const...() instead of c...() but since this method is const, shouldn't be neccessary to begin with
This seems unused
We do a double lookup here, contains() and then operator afterwards, should be combined to a single find()
Yes, the check is in the loop below: after and before are of the same sizes, and if after contains each key from before, then their keys are equal. So return false if a key can't be found in after.