step/mainwindow.cc
47	Did you check if there are no visual regressions when porting to QStatusBar? The KDELibs version did a few things differently.
step/worldscene.cc
129	You can combine `resetMatrix()` + `setTransform(..., true)` with `setTransform(..., false)`

yurchor marked 2 inline comments as done.Oct 3 2018, 7:57 PM

yurchor added inline comments.

step/mainwindow.cc
47	For now, the only thing the statusBar does is just "show()". So no regressions expected.
step/worldscene.cc
129	Fixed. Thanks.

Fix setTransform

Changes look good to me overall. +1

step/mainwindow.cc
50	Should be `KNS3/DownloadDialog` to match the others.

Fine-tune the includes

cfeck added inline comments.Oct 3 2018, 10:13 PM

step/gascreationdialog.h
41	Maybe completely remove the Qt::WindowFlags stuff. In older Qt versions, it wasn't optional, and some previous porting retained it. I think we removed it elsewhere.

Remove window flags

cfeck accepted this revision.Oct 4 2018, 7:37 PM

This revision is now accepted and ready to land.Oct 4 2018, 7:37 PM

Closed by commit R341:6122f5d68897: Port Step away from kdelibs4support (authored by yurchor). · Explain WhyOct 4 2018, 7:41 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			CMakeLists.txt (2 lines)
M			step/CMakeLists.txt (6 lines)
M			step/gascreationdialog.h (2 lines)
M			step/gascreationdialog.cc (4 lines)
M			step/gasgraphics.cc (4 lines)
M			step/infobrowser.h (2 lines)
M			step/infobrowser.cc (4 lines)
M			step/itempalette.h (2 lines)
M			step/itempalette.cc (4 lines)
M			step/mainwindow.cc (5 lines)
M			step/messageframe.h (2 lines)
M			step/messageframe.cc (4 lines)
M			step/particlegraphics.cc (2 lines)
M			step/polygongraphics.cc (2 lines)
M			step/propertiesbrowser.h (2 lines)
M			step/propertiesbrowser.cc (10 lines)
M			step/softbodygraphics.cc (2 lines)
M			step/stepgraphicsitem.h (2 lines)
M			step/stepgraphicsitem.cc (8 lines)
M			step/toolgraphics.cc (11 lines)
M			step/undobrowser.h (2 lines)
M			step/undobrowser.cc (4 lines)
M			step/worldbrowser.h (2 lines)
M			step/worldbrowser.cc (4 lines)
M			step/worldmodel.cc (12 lines)
M			step/worldscene.cc (5 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	42811			Oct 3 2018, 6:42 PM	★	★
Diff 2	42814			Oct 3 2018, 7:57 PM	★	★
Diff 3	42819			Oct 3 2018, 9:45 PM	★	★
Diff 4	42833			Oct 4 2018, 6:01 AM	★	★
Diff 5	42887	7055302	R341:6122f5d6889766f19515f00fb6387cc36ec0e7be	Oct 4 2018, 7:40 PM	★	★

Port Step away from kdelibs4support
ClosedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 42887

CMakeLists.txt

step/CMakeLists.txt

step/gascreationdialog.h

step/gascreationdialog.cc

step/gasgraphics.cc

step/infobrowser.h

step/infobrowser.cc

step/itempalette.h

step/itempalette.cc

step/mainwindow.cc

step/messageframe.h

step/messageframe.cc

step/particlegraphics.cc

step/polygongraphics.cc

step/propertiesbrowser.h

step/propertiesbrowser.cc

step/softbodygraphics.cc

step/stepgraphicsitem.h

step/stepgraphicsitem.cc

step/toolgraphics.cc

step/undobrowser.h

step/undobrowser.cc

step/worldbrowser.h

step/worldbrowser.cc

step/worldmodel.cc

step/worldscene.cc

Port Step away from kdelibs4supportClosedPublicActions