[Shell Runner] Add "Run in Terminal" option
ClosedPublic

Authored by broulik on May 11 2016, 6:11 PM.

Details

Summary

This allows to run the given command in a terminal window.

The runner used to have a "Run as other user" option but since it's widget-based and nowadays we usually discourage this and it's an even more advanced option, I'm not really into coming up with a solution for that.

Test Plan

Usability: this is really only for the "Shell" runner, ie. if I enter "Dolphin" and find it in "Applications" it won't have this option.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik updated this revision to Diff 3769.May 11 2016, 6:11 PM
broulik retitled this revision from to [Shell Runner] Add "Run in Terminal" option.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Plasma, Plasma: Design.
broulik set the repository for this revision to R120 Plasma Workspace.
broulik added a project: Plasma.
Restricted Application added a subscriber: plasma-devel. · View Herald TranscriptMay 11 2016, 6:11 PM
broulik edited the test plan for this revision. (Show Details)May 11 2016, 6:12 PM

Yup, makes sense!

mart accepted this revision.May 12 2016, 10:51 AM
mart added a reviewer: mart.
mart added a subscriber: mart.
mart added inline comments.
runners/places/placesrunner.h
53

this seems an unrelated change?

runners/shell/shellrunner.h
50

cleanup of this maybe in separate commit?

This revision is now accepted and ready to land.May 12 2016, 10:51 AM
This revision was automatically updated to reflect the committed changes.