Replace "Shutdown" with "Shut Down" in user-facing strings
ClosedPublic

Authored by ngraham on Mon, Oct 1, 1:32 PM.

Details

Summary

"Shutdown" is a noun ("The nuclear reactor is experiencing a shutdown!")

"Shut Down" is an imperative command with a verb ("Shut down the nuclear reactor!"), which is how everything else is phrased.

Test Plan
  • Login screen button now says "Shut Down"
  • Searching for "shut down" in KRunner brings up the appropriate option ("shutdown" still works too)
  • KRunner says, "Shut down the computer"

Diff Detail

Repository
R120 Plasma Workspace
Branch
shutdown-to-shut-down (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3395
Build 3413: arc lint + arc unit
ngraham created this revision.Mon, Oct 1, 1:32 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMon, Oct 1, 1:32 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Mon, Oct 1, 1:32 PM
davidedmundson accepted this revision.Mon, Oct 1, 1:46 PM
davidedmundson added a subscriber: davidedmundson.

I'm going to merge the other patch into stable, I can do that now, then when that's merged you can add the change there too.

This revision is now accepted and ready to land.Mon, Oct 1, 1:46 PM
ngraham updated this revision to Diff 42664.Mon, Oct 1, 1:51 PM

Fix one more that was just introduced on master

All good now, @davidedmundson?

What does i18nd() mean? Should that now be changed to regular old i18nc() on master?

i18nd == stating what catalog to load from

the qml needs it because the logout greeter code doesn't set the domain
my code had it because it was doing something very naughty and grabbing a translation from some other bit of code

We probablyshould change it to i18n / i18nc in master

We probably should change it to i18n / i18nc in master

OK, I can do that after this lands.

ngraham closed this revision.Mon, Oct 1, 2:50 PM

We probably should change it to i18n / i18nc in master

OK, I can do that after this lands.

D15881: [ksmserver] change i18nd to i18nc