[Notifications] Unbreak notification actions
ClosedPublic

Authored by broulik on May 9 2016, 5:22 PM.

Details

Summary

The change back to a MouseEventListener broke notification actions because its onClicked handler would fire before the action buttons closing the notification before it had a chance to trigger the action.

Test Plan

I'm not sure we can rely on the order of events but I suppose MEL filters from parent to child?

In any way we should avoid the close call after triggering an action.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 3730.May 9 2016, 5:22 PM
broulik retitled this revision from to [Notifications] Unbreak notification actions.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R120 Plasma Workspace.
broulik added a project: Plasma.
Restricted Application added a subscriber: plasma-devel. · View Herald TranscriptMay 9 2016, 5:22 PM

Ok, no, we need a more sophisticated solution... the "configure" and "close" button are also broken.

mart accepted this revision.May 10 2016, 11:37 AM
mart added a reviewer: mart.
This revision is now accepted and ready to land.May 10 2016, 11:37 AM
This revision was automatically updated to reflect the committed changes.