Differential D15732

Ignore default null eol in Session::sendTextToTerminal
ClosedPublic
Actions

Authored by pavelkh on Sep 24 2018, 2:22 PM.

Details

Reviewers
hindenburg
Group Reviewers
Konsole
Commits
R319:3dad0d6209fc: Ignore default null eol in Session::sendTextToTerminal
Summary

Fixes a bug that currently affects Konsole KPart

Repro steps:

  • Create KPart, and start xxd in it.
  • Call konsolePart->sendInput("hello")
  • In the konsole, press Return, then Ctrl+D

Here's xxd output:
00000000: 6865 6c6c 6f00 0a hello..

The valid xxd output would be:
00000000: 6865 6c6c 6f0a hello.

Null bytes are mostly ignored, but some programs (e.g. ipython interpreter) really don't like them.

The bug happens, since konsole part uses activeSession()->sendTextToTerminal(text);, and sendTextToTerminal() eol parameter defaults to null character.

This diff makes sendTextToTerminal() ignore null eol character.

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
pavelkh created this revision.Sep 24 2018, 2:22 PM
Restricted Application added a subscriber: konsole-devel. · View Herald TranscriptSep 24 2018, 2:22 PM
pavelkh requested review of this revision.Sep 24 2018, 2:22 PM
hindenburg accepted this revision.Sep 26 2018, 3:13 AM
hindenburg added a subscriber: hindenburg.

thanks

This revision is now accepted and ready to land.Sep 26 2018, 3:13 AM
Closed by commit R319:3dad0d6209fc: Ignore default null eol in Session::sendTextToTerminal (authored by hindenburg). · Explain WhySep 27 2018, 1:54 AM
This revision was automatically updated to reflect the committed changes.
shubham added a subscriber: shubham.Oct 21 2018, 5:45 AM

@hindenberg I think you forgot to credit Pavel

Revision Contents
Changeset List

PathPackages
Msrc/Session.cpp (6 lines)

Diff 42407

View Options

src/Session.cpp

Loading...