run grantleeheaderstyleplugin against examples.
Details
Details
- Reviewers
dfaure - Group Reviewers
KDE PIM - Commits
- R81:927b5aeca234: Prepare environment to be able to test grantleeheaderstyle.
Diff Detail
Diff Detail
- Repository
- R81 KDE PIM Addons
- Branch
- dev
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 6627 Build 6645: arc lint + arc unit
Comment Actions
@dfaure: you made tests form frameworks run without installing, so maybe there are already some ecm foo available for that...
Comment Actions
No ECM foo for local copying, so this CMakeLists.txt looks fine to me.
| plugins/messageviewerheaderplugins/autotests/grantleeheaderstyleplugintest.cpp | ||
|---|---|---|
| 46 | KDEHOME? This isn't 2011 anymore. Nothing uses KDEHOME anymore, you can remove that. QStandardPaths::setTestModeEnabled(true); would be a better thing to call here instead. | |
| 47 | Note that this will have no effect on Windows, so for now you'll have to skip anything that relies on this, if Q_OS_WIN. A proper fix (QT_DATA_DIRS) is coming soon hopefully. | |
| 109 | No way to QCOMPARE that? Right now this method looks suspiciously like the previous one... | |
| plugins/messageviewerheaderplugins/autotests/grantleeheaderstyleplugintest.cpp | ||
|---|---|---|
| 46 | but with QStandardPaths::setTestModeEnabled(true); i have no control over the XDG_DATA_HOME, so how I know on cmake where to copy files? | |
| 47 | Any ideas how to get it working on widows, too? | |
| 109 | the test initself it not ready - I'll plan a complete test of the grantlee header files. But befor doing that I need a propper way to access the files. That's why I did not implemented the test completly on that review request. | |
Comment Actions
Make the "prepare enviornemt" solution more bullet proof taking comments into account.
| plugins/messageviewerheaderplugins/autotests/grantleeheaderstyleplugintest.cpp | ||
|---|---|---|
| 47 | Installing the files in one the dirs returned for GenericDataLocation, see QStandardPaths documentation. $QT_DATA_DIRS was shot down. | |