Differential D15697

Fix deletion of files from DAV
ClosedPublic
Actions

Authored by dvratil on Sep 22 2018, 8:09 PM.

Details

Reviewers
dfaure
Commits
R241:7615e3405c30: Fix deletion of files from DAV
Summary

Don't append slash to the end of what we assume is a directory path as
in the case of HTTP we can't always tell for sure if it's a file or a
directory.

This partially restores change 1bdb286 from Dawit.

BUG: 355441
FIXED-IN: 5.51

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dvratil created this revision.Sep 22 2018, 8:09 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 22 2018, 8:09 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
dvratil requested review of this revision.Sep 22 2018, 8:09 PM
dfaure added a comment.Sep 23 2018, 10:08 AM

Patch looks ok but I'm surprised by the commit log. Doesn't this method also work for directories, even after the patch?

dvratil updated this revision to Diff 42175.Sep 23 2018, 10:26 AM

Improve commit message

I thought you were referring to rmdir in the kio slave, but now I
realize rmdir() is KIO API, not slave API.

dvratil edited the summary of this revision. (Show Details)Sep 23 2018, 10:27 AM
dfaure accepted this revision.Sep 23 2018, 10:28 AM
This revision is now accepted and ready to land.Sep 23 2018, 10:28 AM
Closed by commit R241:7615e3405c30: Fix deletion of files from DAV (authored by dvratil). · Explain WhySep 23 2018, 4:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/ioslaves/http/http.cpp (8 lines)

Diff 42192

View Options

src/ioslaves/http/http.cpp

Loading...