Differential D15686

Prevent highlighter from erasing selected text
ClosedPublic
Actions

Authored by sdepiets on Sep 22 2018, 8:13 AM.

Details

Reviewers
mlaurent
dfaure
Group Reviewers
Framework: Syntax Highlighting
Commits
R246:ffd715bc17b3: Prevent highlighter from erasing selected text
Summary

https://phabricator.kde.org/D14447 introduced a regression on Lokalize, the slotRehighlight method is called when text is selected and the insertText(QString()) call inside that method removes all text selected in the cursor.

Clearing the selection before doing that call solves this issue.

BUG: 398661

Diff Detail

Repository
R246 Sonnet
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3112
Build 3130: arc lint + arc unit
sdepiets created this revision.Sep 22 2018, 8:13 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 22 2018, 8:13 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
sdepiets requested review of this revision.Sep 22 2018, 8:13 AM
dfaure added a comment.Sep 22 2018, 8:32 AM

Makes sense.

src/ui/highlighter.cpp
198

coding style: join with previous line

sdepiets updated this revision to Diff 42121.Sep 22 2018, 8:33 AM

Coding style

dfaure accepted this revision.Sep 22 2018, 8:35 AM
This revision is now accepted and ready to land.Sep 22 2018, 8:35 AM
sdepiets closed this revision.Sep 22 2018, 8:40 AM

Revision Contents
Changeset List

PathPackages
Msrc/ui/highlighter.cpp (3 lines)

Diff 42121

View Options

src/ui/highlighter.cpp

Loading...