Sonnet: setLanguage should schedule a rehighlight if highlight is enabled
ClosedPublic

Authored by dfaure on Jul 28 2018, 10:37 PM.

Details

Summary

... even if automatic enabling/disabling is off, as is the case in KMail.

This will allow removing a direct call to rehighlight() in kpimtextedit
which leads to the full highlighting being done twice (very slow on very
large emails).

Test Plan

Replying to a mail in kmail and watching how many times
slotRehighlight is called. Well, this commit alone makes it worse,
but after a fix in kpimtextedit, it's down from 2 to 1.

Diff Detail

Repository
R246 Sonnet
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1316
Build 1334: arc lint + arc unit
dfaure created this revision.Jul 28 2018, 10:37 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 28 2018, 10:37 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
dfaure requested review of this revision.Jul 28 2018, 10:37 PM
mlaurent accepted this revision.Jul 29 2018, 10:48 AM
This revision is now accepted and ready to land.Jul 29 2018, 10:48 AM
dfaure closed this revision.Jul 29 2018, 11:13 AM