[System Tray] Fix assigning global shortcuts to applets from the config interface
ClosedPublic
Actions

Authored by broulik on May 8 2016, 9:39 PM.

Details

Reviewers

Group Reviewers

Commits

Summary

The model has changed and is now created in JS but the code that changes the shortcuts was never adjusted

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

broulik retitled this revision from to [System Tray] Fix assigning global shortcuts to applets from the config interface.

broulik updated this object.

broulik edited the test plan for this revision. (Show Details)

broulik added a reviewer: Plasma.

broulik set the repository for this revision to R120 Plasma Workspace.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

mart added a reviewer: mart.

mart added a subscriber: mart.

mart added inline comments.

applets/systemtray/package/contents/ui/ConfigEntries.qml
233 ↗	(On Diff #3710)	may be more robust if the type (sni or applet) is actually a role in the model?

This revision is now accepted and ready to land.May 10 2016, 11:38 AM

applets/systemtray/package/contents/ui/ConfigEntries.qml
233 ↗	(On Diff #3710)	visible: modelData.hasOwnProperty("shortcut") The shortcut item is only shown for applets

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			applets/systemtray/package/contents/ui/ConfigEntries.qml (7 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	3710			May 8 2016, 9:38 PM	★	★
Diff 2	3751	6326af4	rPLASMAWORKSPACE7bfd0b03c44669c4147bb123ea47b3472ebe64d0	May 10 2016, 5:20 PM	★	★