Differential D15676

[sftp] Disable enqueueChunks debug messages
ClosedPublic
Actions

Authored by asn on Sep 21 2018, 1:17 PM.

Details

Reviewers
sitter
ngraham
Summary

These should only be enabled if we want tracing. However there is no
support for this yet and currently not needed for this code.

BUG: 368877

Signed-off-by: Andreas Schneider <asn@cryptomilk.org>

Diff Detail

Branch
arcpatch-D15676_1
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3176
Build 3194: arc lint + arc unit
asn requested review of this revision.Sep 21 2018, 1:17 PM
asn created this revision.
broulik added a subscriber: broulik.Sep 24 2018, 11:55 AM

lgtm
Keyword is BUG: 368877, note the colon

asn added a comment.Sep 24 2018, 12:34 PM

Should I fix the commit message and just push it, or do you want to do it.

ngraham added a comment.Sep 24 2018, 12:51 PM

I say you go ahead. If you change it gete on Phabricator, you need to run arc amend locally to update the local commit message.

asn updated this revision to Diff 42238.Sep 24 2018, 12:56 PM

Fix BUG:

asn edited the summary of this revision. (Show Details)Sep 24 2018, 1:04 PM
ngraham accepted this revision.Sep 24 2018, 1:11 PM
This revision is now accepted and ready to land.Sep 24 2018, 1:11 PM
asn updated this revision to Diff 42245.Sep 24 2018, 1:28 PM

Remove abandoned revsions

Revision Contents
Changeset List

PathPackages
Msftp/kio_sftp.cpp (6 lines)

Diff 42245

View Options

sftp/kio_sftp.cpp

Loading...