altered references to 0 in null pointers
ClosedPublic

Authored by carlos_hdc on Sep 17 2018, 7:11 PM.

Details

Summary

Remove warnings by removing 0 to nullptr where applicable

Diff Detail

Repository
R326 Kalzium
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
carlos_hdc created this revision.Sep 17 2018, 7:11 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptSep 17 2018, 7:11 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
carlos_hdc requested review of this revision.Sep 17 2018, 7:11 PM

You added a wrong file to the commit, please remove the CMaleLists.txt.user, also try to reason with the change: some elements that you changed the 0 to nullptr makes sense but others should be refactored to not use pointers.

I know this is out of the scope of this patch, so I'll accept as soon as you remove the CMALELISTS.txt.user

src/kalziumutils.cpp
131

Why thIs change? Also don't commit commented code.

tcanabrava requested changes to this revision.Sep 17 2018, 8:46 PM
This revision now requires changes to proceed.Sep 17 2018, 8:46 PM
carlos_hdc updated this revision to Diff 41901.Sep 18 2018, 1:52 PM
  • Ignore qt creator cmake project file.
tcanabrava accepted this revision.Sep 18 2018, 1:57 PM
tcanabrava edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Sep 18 2018, 1:58 PM
This revision was automatically updated to reflect the committed changes.