You added a wrong file to the commit, please remove the CMaleLists.txt.user, also try to reason with the change: some elements that you changed the 0 to nullptr makes sense but others should be refactored to not use pointers.

I know this is out of the scope of this patch, so I'll accept as soon as you remove the CMALELISTS.txt.user

src/kalziumutils.cpp
131	Why thIs change? Also don't commit commented code.

tcanabrava requested changes to this revision.Sep 17 2018, 8:46 PM

This revision now requires changes to proceed.Sep 17 2018, 8:46 PM

Ignore qt creator cmake project file.

Harbormaster completed remote builds in B2989: Diff 41901.Sep 18 2018, 1:52 PM

tcanabrava accepted this revision.Sep 18 2018, 1:57 PM

tcanabrava edited the summary of this revision. (Show Details)

This revision is now accepted and ready to land.Sep 18 2018, 1:58 PM

Closed by commit R326:fda9422d1f82: altered references to 0 in null pointers (authored by carlos_hdc, committed by tcanabrava). · Explain WhySep 18 2018, 1:59 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		.arcconfig (4 lines)
A	M	CMakeLists.txt.user (844 lines)
M		compoundviewer/kalziumglwidget.cpp (2 lines)
M		libscience/elementparser.cpp (4 lines)
M		libscience/isotopeparser.cpp (4 lines)
M		libscience/moleculeparser.cpp (4 lines)
M		libscience/psetables.cpp (6 lines)
M		libscience/spectrumparser.cpp (6 lines)
M		src/detailedgraphicaloverview.cpp (2 lines)
M		src/detailinfodlg.cpp (2 lines)
M		src/elementdataviewer.cpp (4 lines)
M		src/exportdialog.cpp (2 lines)
M		src/kalzium.cpp (24 lines)
M		src/kalziumdataobject.cpp (6 lines)
M		src/kalziumgradienttype.cpp (6 lines)
M		src/kalziumnumerationtype.cpp (6 lines)
M		src/kalziumschemetype.cpp (6 lines)
M		src/kalziumutils.cpp (5 lines)
M		src/kdeeduglossary.cpp (2 lines)
M		src/main.cpp (2 lines)
M		src/rsdialog.cpp (2 lines)
M		src/searchwidget.cpp (2 lines)
M		src/spectrumviewimpl.cpp (2 lines)
M		src/spectrumwidget.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	41862	f3bea36		Sep 17 2018, 7:11 PM	★	★
Diff 2	41901	f3bea36	- Ignore qt creator cmake project file.	Sep 18 2018, 1:52 PM	★	★
Diff 3	41903	f3bea36	R326:fda9422d1f82ca162d9a866da0cfec813b30f81f	Sep 18 2018, 1:59 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
40e78a946682	dedb9b88c746	60d8dd5721b5	Carlos Henrique D. C. Santos	Adding arcconfig	Sep 17 2018, 4:55 PM
60d8dd5721b5	9baf8d77ddb7	f3bea369b8e3	Carlos Henrique D. C. Santos	altered references to 0 in null pointers	Sep 17 2018, 4:29 PM