Differential D15572

[Terminal Display] Hide search bar on ESC
ClosedPublic
Actions

Authored by anthonyfieroni on Sep 17 2018, 11:45 AM.

Details

Reviewers
tcanabrava
hindenburg
Group Reviewers
Konsole
Commits
R319:f93263d6b4dc: [Terminal Display] Hide search bar on ESC

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Konsole. · View Herald TranscriptSep 17 2018, 11:45 AM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
anthonyfieroni requested review of this revision.Sep 17 2018, 11:45 AM
tcanabrava requested changes to this revision.Sep 17 2018, 12:51 PM
tcanabrava added inline comments.
src/TerminalDisplay.cpp
3598

if (_searchBar->isVisible() && ...) ?

This revision now requires changes to proceed.Sep 17 2018, 12:51 PM
anthonyfieroni updated this revision to Diff 41826.Sep 17 2018, 12:54 PM
anthonyfieroni marked an inline comment as done.
tcanabrava accepted this revision.Sep 17 2018, 12:56 PM
This revision is now accepted and ready to land.Sep 17 2018, 12:56 PM
Closed by commit R319:f93263d6b4dc: [Terminal Display] Hide search bar on ESC (authored by anthonyfieroni). · Explain WhySep 17 2018, 1:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/TerminalDisplay.cpp (4 lines)

Diff 41838

View Options

src/TerminalDisplay.cpp

Loading...