Add QT_NO_NARROWING_CONVERSIONS_IN_CONNECT as default compile flags
ClosedPublic
Actions

Authored by mlaurent on Sep 17 2018, 5:38 AM.

Details

Reviewers

dfaure

Commits

Summary

Use QT_NO_NARROWING_CONVERSIONS_IN_CONNECT as default flags

Repository

R240 Extra CMake Modules

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

mlaurent requested review of this revision.Sep 17 2018, 5:38 AM

Do all frameworks build with this change?

I fixed 2 repos.
Otherwise all compiles fine (ok I don't test on windows/mac and perhaps some module is not compiles on my computer)

Ping?

This revision is now accepted and ready to land.Sep 22 2018, 1:52 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			kde-modules/KDEFrameworkCompilerSettings.cmake (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	41793	28da9e6		Sep 17 2018, 5:38 AM	★	★
Diff 2	42140	b322901	R240:9b528012703ae584e80a4954df153091a1443be9	Sep 22 2018, 5:07 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
19e024013a84	973475bf1083	28da9e614f66	Laurent Montel	Add QT_NO_NARROWING_CONVERSIONS_IN_CONNECT as default compile flags (Show More…)	Sep 17 2018, 5:37 AM