Avoid potential clashes on symbols/macros from other libraries
Allows to use the generated header in projects which have
DQT_NO_SIGNALS_SLOTS_KEYWORDS or DQT_NO_KEYWORDS set
Details
Details
Diff Detail
Diff Detail
- Repository
- R881 Rust Qt Binding Generator
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Better safe than sorry. I was not familiar with this practice. I looked for some information on it and found these https://www.kdab.com/kdab-contributions-to-qt-5-0-part-5/ I found no qt.io docs on QT_NO_SIGNALS_SLOTS_KEYWORDS but using Q_SIGNALS is listed as a good idea at http://doc.qt.io/qt-5/qobject.html#Q_SIGNALS.
Should the code also be using Q_EMIT?
Comment Actions
Indeed. I was so used to these defines I did not know they are undocumented. Filed https://bugreports.qt.io/browse/QTBUG-70564 to have this sorted out.
Should the code also be using Q_EMIT?
Indeed, that should help people who even use QT_NO_KEYWORDS in their code. Will do another patch for that. Also one coming up with a 0->nullptr change :)