Keep org.freedesktop.FileManager1 registered across processes
ClosedPublic

Authored by davidedmundson on Sep 15 2018, 5:00 PM.

Details

Summary

Currently if someone starts 2 dolphins, the second cannot register
org.freedesktop.FileManager1 meaning and when the first dolphin quits,
no-one has it registered.

It doesn't cause a huge problem right now as we just dbus-activate a new one if
needed, but it means the behaviour is a bit inconsistent and
non-optimal.

DBus has a system to queue names, meaning that as long as any dolphin is
running this name is owned by one of the processes.

Also this patch registers the service after the object which is
technically safer.

Test Plan

Ran d-feet
Opened 2 dolphins, closed the first
Service was still registered and the PID of the owning process changed.

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Sep 15 2018, 5:00 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptSep 15 2018, 5:00 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
davidedmundson requested review of this revision.Sep 15 2018, 5:00 PM
This revision is now accepted and ready to land.Sep 16 2018, 8:47 AM
This revision was automatically updated to reflect the committed changes.