Creating an icon requires setting up a KIconLoader which in turn loads and processes icon themes, accounting to 10% of the daemon's startup time.
All the daemon mode does is start new Dolphin processes, it doesn't show any windows.
Details
Details
- Reviewers
davidedmundson - Group Reviewers
Dolphin
Should also save some ram but didn't notice any changes there
- Dolphin windows still have a window icon
- Doing "open containing folder" in an app for the first time feels quicker
(imho the "daemon" should quit after having fullfilled the dbus activation request but that's an unrelated issue)
The plasma-integration platform theme still creates a KIconLoader, so this is probably moot. :/ If we could/would use QCommandLineParser before creating the QApplication we could set desktopSettingsAware to false to prevent all of this
Diff Detail
Diff Detail
- Repository
- R318 Dolphin
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
(imho the "daemon" should quit after having fullfilled the dbus activation request but that's an unrelated issue)
IMHO the Dolphin::openNewWindow code should be changed to
if (!MainWindow) {
make a new MainWindow
} else {
spawn like it does now
}Having an entire instance of dolphin that can sit there forever with no UI only to spawn other dolphin instances is the inefficient odd part and trying to optimise the --daemon mode is going in the wrong direction.