Differential D15498

Workaround QTBUG-47066 to fix crash on startup
ClosedPublic
Actions

Authored by fvogt on Sep 14 2018, 9:35 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R123:a21dd3486b12: Workaround QTBUG-47066 to fix crash on startup
R123:0497a6e917c9: Workaround QTBUG-47066 to fix crash on startup
Summary

The lambda returns a QStringBuilder which contains dangling references.
Work around that by converting to QString inside the lambda's context.

Test Plan

Does not crash anymore.

Diff Detail

Repository
R123 SDDM Configuration Panel (KCM)
Branch
Plasma/5.12
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2844
Build 2862: arc lint + arc unit
fvogt created this revision.Sep 14 2018, 9:35 AM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 14 2018, 9:35 AM
fvogt requested review of this revision.Sep 14 2018, 9:35 AM
davidedmundson accepted this revision.Sep 14 2018, 9:58 AM
This revision is now accepted and ready to land.Sep 14 2018, 9:58 AM
Closed by commit R123:a21dd3486b12: Workaround QTBUG-47066 to fix crash on startup (authored by fvogt). · Explain WhySep 14 2018, 12:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/sddmkcm.cpp (6 lines)

Diff 41622

View Options

src/sddmkcm.cpp

Loading...