Fix CMakeLists.txt issues
ClosedPublic
Actions

Authored by poboiko on Sep 14 2018, 8:44 AM.

Details

Reviewers

dvratil
apol

Group Reviewers

Frameworks

Commits

R307:13d933732b78: Fix CMakeLists.txt issues

Summary

Remove redundant install(FILES) and fix PREFIX for KPeople/Widgets (so pretty CamelCase headers would work)

Test Plan

It compiles, it works.

Repository

R307 KPeople

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

poboiko requested review of this revision.Sep 14 2018, 8:44 AM

dvratil requested changes to this revision.Sep 14 2018, 10:45 AM

dvratil added inline comments.

src/declarative/personactionsmodel.cpp
20–21	This looks suspicious. When compiling, you should not need to refer to `<kpeople/...>`, the includes should actually be #include "persondata.h" #include "widgets/actions.h" otherwise, there's a risk that a wrong header gets included from installed KPeople instead of from the source tree. I suspect this module lived elsewhere and got just moved into KPeople without adjusting the includes.

This revision now requires changes to proceed.Sep 14 2018, 10:45 AM

Fixed global includes

poboiko marked an inline comment as done.Sep 14 2018, 11:57 AM

Thanks!

This revision is now accepted and ready to land.Sep 14 2018, 12:26 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/declarative/personactionsmodel.cpp (4 lines)
M			src/widgets/CMakeLists.txt (8 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	41612	c39df38		Sep 14 2018, 8:44 AM	★	★
Diff 2	41641	c39df38	Fixed global includes	Sep 14 2018, 11:57 AM	★	★
Diff 3	41643	c39df38	R307:13d933732b7885f965017fa9df24e7e3648c7ef5	Sep 14 2018, 12:32 PM	★	★