introduce BaseTheme to allow inheritage between platform themes
ClosedPublic
Actions

Authored by mgallien on Sep 11 2018, 8:15 PM.

Details

Reviewers

astippich
januz

Commits

R255:be6b602d437b: introduce BaseTheme to allow inheritage between platform themes

Summary

BaseTheme is the new component where all common definitions should go.
When something specific needs to be done, it should go in the appropriate
platform specific theme

Test Plan

linux version is unchanged but its theme component is now empty

Diff Detail

Repository

R255 Elisa

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

mgallien requested review of this revision.Sep 11 2018, 8:15 PM

mgallien created this revision.

Harbormaster completed remote builds in B2736: Diff 41434.Sep 11 2018, 8:15 PM

mgallien mentioned this in D15308: allow ViewSelector to show icon only when the window is small.Sep 11 2018, 8:16 PM

Nice!

This revision is now accepted and ready to land.Sep 13 2018, 5:40 PM

Closed by commit R255:be6b602d437b: introduce BaseTheme to allow inheritage between platform themes (authored by mgallien). · Explain WhySep 13 2018, 6:45 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/CMakeLists.txt (1 line)
P			src/qml/BaseTheme.qml Copied from src/qml/Theme.qml
P			src/qml/Theme.qml (100 lines) Copied to src/qml/BaseTheme.qml
M			src/resources.qrc (1 line)
M			src/windows/WindowsTheme.qml (94 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	41434	4ab02eb		Sep 11 2018, 8:15 PM	★	★
Diff 2	41568	4ab02eb	R255:be6b602d437b5bb80edc1a8891cd17d93bcef5a5	Sep 13 2018, 6:45 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
850a93057917	f984144b9d60	4ab02ebfef7d	Matthieu Gallien	introduce BaseTheme to allow inheritage between platform themes (Show More…)	Sep 11 2018, 8:13 PM