[Desktop] Allow SMS app to handle newly recieved messages
ClosedPublic

Authored by sredman on Sep 10 2018, 3:41 PM.

Details

Summary

Update sms app model to use new conversationUpdated signal

Filter incoming messages which belong to a different conversation than the one currently being viewed

See Android-side diff D15360 which adds support for sending live updates when a new message is sent or received

Test Plan

This patch relies on D15360 for Android-side support

  • Positive case:
    • Open a conversation in the SMS app
    • Receive a new message into that conversation (text yourself?)
    • Verify that the new message appears at the bottom of the appropriate conversation
  • Negative case:
    • Open a conversation in the SMS app
    • Receive a new message into a different conversation (text yourself?)
    • Verify that the new message does *not* appear in the open conversation

Diff Detail

Repository
R224 KDE Connect
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sredman created this revision.Sep 10 2018, 3:41 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptSep 10 2018, 3:41 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
sredman requested review of this revision.Sep 10 2018, 3:41 PM
sredman updated this revision to Diff 41510.Sep 12 2018, 10:42 PM

Remove sneaky modification of SMS plugin icon

nicolasfella added inline comments.
smsapp/conversationmodel.cpp
70

Please use the new connect syntax.

connect(sender, &Sender::signal, receiver, &Receiver::slot)
sredman added inline comments.Sep 15 2018, 9:21 PM
smsapp/conversationmodel.cpp
70

It looks like, because of the way our build system builds the dbus interfaces, the member function definitions are not available to the linker to build the plugin (or, in this case, model). Changing to the new syntax gives lots of undefined reference errors, which is why we rely on runtime connections. Does anyone have a way around this?

sredman updated this revision to Diff 41753.Sep 16 2018, 5:18 PM

Implement ContentObserver to listen for incoming/outgoing messages and report those to the remote

sredman updated this revision to Diff 41755.Sep 16 2018, 5:20 PM

Accidentally uploaded Android-side patch onto KDE-side diff...

sredman retitled this revision from [WIP] Allow SMS app to handle newly recieved messages to Allow SMS app to handle newly recieved messages.Sep 16 2018, 5:24 PM
sredman edited the summary of this revision. (Show Details)
sredman retitled this revision from Allow SMS app to handle newly recieved messages to [Desktop] Allow SMS app to handle newly recieved messages.Sep 16 2018, 5:32 PM
nicolasfella accepted this revision.Sep 16 2018, 9:59 PM
This revision is now accepted and ready to land.Sep 16 2018, 9:59 PM
This revision was automatically updated to reflect the committed changes.