Unit tests for the R indent script
ClosedPublic

Authored by devillemereuil on Sep 8 2018, 2:44 PM.

Details

Summary

A series of unit tests as was request in this previous review of the R indent script.

Test Plan

The tests were... well, tested using kateindenttest built from sources (master) and were running OK.

Diff Detail

Repository
R39 KTextEditor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
devillemereuil created this revision.Sep 8 2018, 2:44 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptSep 8 2018, 2:44 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
devillemereuil requested review of this revision.Sep 8 2018, 2:44 PM
cullmann accepted this revision.Sep 8 2018, 2:45 PM
cullmann added a subscriber: cullmann.

Hi, thanks for that!
Can you push yourself or shall I push your indenter + tests?
Thanks for taking the time to create some tests!

This revision is now accepted and ready to land.Sep 8 2018, 2:45 PM

I thought this phabricator review served as a push request? How can I push the revision myself? Can I push directly on annongit.kde.org? (Sorry for being yet again a newb!)

:=)

To push, you need some developer account, then you can just push to git.kde.org.
It is no problem for me to just do that for you, like last time.

I think for this time, it is the easiest and fastest thing that I just land your patches.

If you want to push yourself in the future, you can apply for an account like described here:
https://community.kde.org/Infrastructure/Get_a_Developer_Account

> Thanks for the work.

Yes, let's do that for now. I'll get an account if this becomes a habit. Thanks for your help!

Ok ;=)
Have pushed the indenter change, need to rebuild my local stuff here with kdesrc-build and will apply + test this change then, too again.
Hope to see more contributions, guess R users will like improved indenting ;=)

This revision was automatically updated to reflect the committed changes.

I needed to adjust R => r as mode, as the basename of the file is used for that, which is r.
Seems to work locally that way, otherwise I got:

org.kde.ktexteditor: mode "R" does not exist