devillemereuil (Pierre de Villemereuil)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Apr 25 2018, 2:48 PM (313 w, 22 h)
Availability
Available

Recent Activity

Sep 8 2018

devillemereuil added a comment to D15350: Unit tests for the R indent script.

Yes, let's do that for now. I'll get an account if this becomes a habit. Thanks for your help!

Sep 8 2018, 2:56 PM · Frameworks, Kate
devillemereuil added a comment to D15350: Unit tests for the R indent script.

I thought this phabricator review served as a push request? How can I push the revision myself? Can I push directly on annongit.kde.org? (Sorry for being yet again a newb!)

Sep 8 2018, 2:51 PM · Frameworks, Kate
devillemereuil requested review of D15350: Unit tests for the R indent script.
Sep 8 2018, 2:44 PM · Frameworks, Kate
devillemereuil requested review of D15349: Update of the R indent script.
Sep 8 2018, 2:40 PM · Frameworks, Kate

Sep 2 2018

devillemereuil added a comment to D12587: Indentation script for R.

Will do. Thanks!

Sep 2 2018, 7:14 PM · Frameworks, Kate
devillemereuil added a comment to D12587: Indentation script for R.

I... git cloned ktexteditor and ran cmake .? Is there a better way? Sorry, I'm a real newb in this as you can probably tell! I'm not a dev by training.

Sep 2 2018, 6:44 PM · Frameworks, Kate
devillemereuil added a comment to D12587: Indentation script for R.

OK. So, that'll require compile ktexteditor from source. I should be able to manage that (I guess?). I'll report here if it gives me too many headaches. I tried today, but gave up because of an issue with ECM (?) version. I got:

Sep 2 2018, 6:40 PM · Frameworks, Kate
devillemereuil added a comment to D12587: Indentation script for R.

That's the thing: I don't know how to run the test. If it requires dealing with cmake and stuff, that's take me a while to figure out. Is there any simple documentation about it?

Sep 2 2018, 6:25 PM · Frameworks, Kate
devillemereuil added a comment to D12587: Indentation script for R.

So, basically, I just write a bunch of tests, commit them here and we'll debug them if needed from here?

Sep 2 2018, 6:21 PM · Frameworks, Kate
devillemereuil added a comment to D12587: Indentation script for R.

Say that I have the files for a unit test (origin, input.js and expected). How can I check the code for the unit test? Is there a way to simply execute the javascript code and verify it does what I expect? It would be a shame to have the unit test fail because of the code test itself.

Sep 2 2018, 6:17 PM · Frameworks, Kate

Aug 15 2018

devillemereuil added a comment to D12587: Indentation script for R.

I might get to that around September (no promise). If people are willing to help, my not-unit-at-all test code for indentation can be found here:
https://github.com/devillemereuil/rindent/blob/master/example.R

Aug 15 2018, 9:07 AM · Frameworks, Kate
devillemereuil added a comment to D12587: Indentation script for R.

Just to say: this didn't fall off my radar. I'm just incredibly busy nowadays and it never quite make it to the top of my todo list... But I think about doing it regularly, which is a good sign it'll happen!

Aug 15 2018, 8:23 AM · Frameworks, Kate

Apr 30 2018

devillemereuil added a comment to D12587: Indentation script for R.

I will have a go at it. It doesn't seem very complicated indeed, but I just don't have much time right now for this.

Apr 30 2018, 8:12 AM · Frameworks, Kate

Apr 29 2018

devillemereuil added a comment to D12587: Indentation script for R.

I think this is very cool. But there is one thing we require for new indenters: unit tests.

There is a subfolder autotest in the KTextEditor git module. Could you have a look into this? Without such automated tests, we will likely introduce regressions in future updates of the indenter. If you need help, please let us know :-)

Apr 29 2018, 9:58 AM · Frameworks, Kate

Apr 28 2018

devillemereuil requested review of D12587: Indentation script for R.
Apr 28 2018, 4:31 PM · Frameworks, Kate