Differential D1525

Make jobs parent-less
ClosedPublic
Actions

Authored by elvisangelaccio on May 2 2016, 2:59 PM.

Details

Reviewers
rthomsen
Commits
R36:268ad34f23f0: Make jobs parent-less
Summary

KJobs autodelete themselves using deleteLater(), when they are done.
So I don't see why our jobs should be children of Archive.

This + D1521 fix the broken password dialog with header-encrypted archives.

Diff Detail

Repository
R36 Ark
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
elvisangelaccio updated this revision to Diff 3607.May 2 2016, 2:59 PM
elvisangelaccio retitled this revision from to Make jobs parent-less.
elvisangelaccio updated this object.
elvisangelaccio added a reviewer: rthomsen.
Restricted Application added a project: Ark. · View Herald TranscriptMay 2 2016, 2:59 PM
Restricted Application added a subscriber: kde-utils-devel. · View Herald Transcript
elvisangelaccio updated this revision to Diff 3626.May 3 2016, 4:58 PM

Rebased agains current master

rthomsen accepted this revision.May 3 2016, 5:24 PM
rthomsen edited edge metadata.

Kill the parents! :)

This revision is now accepted and ready to land.May 3 2016, 5:24 PM
Closed by commit R36:268ad34f23f0: Make jobs parent-less (authored by elvisangelaccio). · Explain WhyMay 6 2016, 4:22 PM
This revision was automatically updated to reflect the committed changes.
elvisangelaccio mentioned this in R36:268ad34f23f0: Make jobs parent-less.

Revision Contents
Changeset List

Diff 3679

View Options

autotests/kerfuffle/jobstest.cpp

Loading...
View Options

kerfuffle/archive_kerfuffle.cpp

Loading...
View Options

kerfuffle/jobs.h

Loading...
View Options

kerfuffle/jobs.cpp

Loading...