Rename failOperation() to killProcess()
ClosedPublic

Authored by elvisangelaccio on May 1 2016, 5:05 PM.

Details

Summary

This is the first step to simplify the signals emitted by CliInterface.
The failOperation() function is used all over the place, while in fact is
just calling doKill(). But after commit 074d527, doKill() doesn't emit anymore finished().

So we fix this by renaming it to a function that actually kills the process and
that may or may not cause the finished() signal to be emitted, depending on the context.

Diff Detail

Repository
R36 Ark
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
elvisangelaccio retitled this revision from to Rename failOperation() to killProcess().
elvisangelaccio updated this object.
elvisangelaccio added a reviewer: rthomsen.
Restricted Application added a project: Ark. · View Herald TranscriptMay 1 2016, 5:05 PM
Restricted Application added a subscriber: kde-utils-devel. · View Herald Transcript
rthomsen accepted this revision.May 2 2016, 5:28 PM
rthomsen edited edge metadata.

Ship it! :)

This revision is now accepted and ready to land.May 2 2016, 5:28 PM