Differential D15243

Remove some double look-ups
ClosedPublic
Actions

Authored by apol on Sep 3 2018, 2:25 PM.

Details

Reviewers
mart
Group Reviewers
Kirigami
Commits
R169:301af35592af: Remove some double look-ups
Test Plan

My apps still work

Diff Detail

Repository
R169 Kirigami
Branch
arcpatch-D15243
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2478
Build 2496: arc lint + arc unit
apol created this revision.Sep 3 2018, 2:25 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptSep 3 2018, 2:25 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested review of this revision.Sep 3 2018, 2:25 PM
apol updated this revision to Diff 40919.Sep 3 2018, 2:37 PM

Add missing part

broulik added a subscriber: broulik.Sep 3 2018, 2:51 PM

+1

src/delegaterecycler.cpp
73 ↗(On Diff #40919)

m_refs.erase(itRef)?

83 ↗(On Diff #40919)

Unrelated question: Where does this get removed from items?

apol marked an inline comment as done.Sep 3 2018, 11:49 PM
apol added inline comments.
src/delegaterecycler.cpp
73 ↗(On Diff #40919)

Thanks!

83 ↗(On Diff #40919)

They are unused items (delegate instances), they get deleted when it's destroyed.
The code looks good to me.

apol updated this revision to Diff 40947.Sep 3 2018, 11:49 PM
apol marked an inline comment as done.

Remove another lookup, thanks Kai!

mart accepted this revision.Sep 4 2018, 1:19 PM
This revision is now accepted and ready to land.Sep 4 2018, 1:19 PM
Closed by commit R169:301af35592af: Remove some double look-ups (authored by apol). · Explain WhySep 4 2018, 1:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/delegaterecycler.cpp (27 lines)

Diff 40947

View Options

src/delegaterecycler.cpp

Loading...