Differential D1524

Actually create the outputmanagement interface
ClosedPublic
Actions

Authored by sebas on May 2 2016, 12:53 PM.

Details

Reviewers
graesslin
Group Reviewers
Plasma
Commits
R108:a5189cc39304: Actually create the outputmanagement interface
Summary

It's instantiated, but never created. This means that libkscreen's wayland backend is going to hang initializing.

Test Plan

Ran libkscreen against it, works with and doesn't work without patch.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sebas updated this revision to Diff 3599.May 2 2016, 12:53 PM
sebas retitled this revision from to Actually create the outputmanagement interface.
sebas updated this object.
sebas edited the test plan for this revision. (Show Details)
sebas added reviewers: Plasma, graesslin.
Restricted Application added a project: Plasma. · View Herald TranscriptMay 2 2016, 12:53 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
graesslin accepted this revision.May 2 2016, 2:47 PM
graesslin edited edge metadata.
This revision is now accepted and ready to land.May 2 2016, 2:47 PM
graesslin added a comment.May 2 2016, 2:48 PM

btw. this screams unit test at me: should be easy to verify. Just try to connect with a client.

graesslin added a comment.May 2 2016, 2:52 PM

btw. this screams unit test at me: should be easy to verify. Just try to connect with a client.

sebas added a comment.May 2 2016, 11:09 PM

For the unit test to be useful, we have to be running kwin_wayland. Can we expect that to be the case?

Closed by commit R108:a5189cc39304: Actually create the outputmanagement interface (authored by sebas). · Explain WhyMay 2 2016, 11:10 PM
This revision was automatically updated to reflect the committed changes.
graesslin added a comment.May 3 2016, 5:41 AM
In D1524#28312, @sebas wrote:

For the unit test to be useful, we have to be running kwin_wayland. Can we expect that to be the case?

Yes of course! That's the point of kwin's tests. Each test starts the full kwin_wayland! So you can just have a test in KWin, create a ClientConnection and try to connect to the interface.

Revision Contents
Changeset List

PathPackages
Mwayland_server.cpp (1 line)

Diff 3618

View Options

wayland_server.cpp

Loading...