Differential D15235

Add craftroot/share to QStandardPaths::GenericDataLocation on MacOS
ClosedPublic
Actions

Authored by arichardson on Sep 3 2018, 10:05 AM.

Details

Reviewers
vonreth
kfunk
Commits
R877:3e88b57c5379: Add craftroot/share to QStandardPaths::GenericDataLocation on MacOS
Summary

Before patch:
$ qtpaths --paths GenericDataLocation
/Users/alex/Library/Application Support:/Users/alex/kde/share:/Library/Application Support:/Users/alex/kde/bin

After this change:
$ qtpaths --paths GenericDataLocation
/Users/alex/Library/Application Support:/Library/Application Support:/Users/alex/kde/bin

Also supported now:
$ QT_DATA_DIRS=/foo/bar qtpaths --paths GenericDataLocation
/Users/alex/Library/Application Support:/foo/bar:/Library/Application Support:/Users/alex/kde/bin

I have added this patch for upstream review as https://codereview.qt-project.org/#/c/238640/

Diff Detail

Repository
R877 Craft Blueprints for KDE
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
arichardson requested review of this revision.Sep 3 2018, 10:05 AM
arichardson created this revision.
vonreth added a comment.Sep 3 2018, 11:05 AM

did you by accident invert the before and after value?

arichardson added a comment.Sep 3 2018, 12:17 PM
In D15235#319464, @vonreth wrote:

did you by accident invert the before and after value?

Ah yes, looks like I pasted the wrong value. Will definitely fix message before committing.

vonreth accepted this revision.Sep 3 2018, 2:18 PM

looks good, in case this gets accepted upstream please keep our version of the patch synced.

This revision is now accepted and ready to land.Sep 3 2018, 2:18 PM
Closed by commit R877:3e88b57c5379: Add craftroot/share to QStandardPaths::GenericDataLocation on MacOS (authored by arichardson). · Explain WhySep 3 2018, 2:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 40917

View Options

libs/qt5/qtbase/qstandardpaths-extra-dirs.patch

Loading...
View Options

libs/qt5/qtbase/qtbase.py

Loading...