I don't think you need this signal.

Just reimplement slotClearHistory in the LineEditWithKeyword subclass (might require marking it virtual in LineEditWithCompleter though).

Put the opening curly brace '{' on its own line.

Put the opening curly brace '{' on its own line.

Put the opening curly brace '{' on its own line.

Should probably be "LineEditWithKeywords" since there's more than one. :-)

Both can be private in my opinion.

Also, name wise you likely want to write "keyword list" everywhere, not "list keyword" (otherwise doesn't read like english).

Try to keep the private at the end of the class definition.

No need to introduce a new empty line here.

Better: replace those two lines with "LineEditWithCompleter::slotClearHistory();"

It'll call the implementation of the base class this way, you won't need to duplicate it.

Keep it private too. Add Q_DECL_OVERRIDE at the end of the line (just before the ';'.

protected would be enough, no need to turn it fully public.

Missing copyrights

why don't assign directly QStringlist ?

> initKeyWordList()

{

keywordlist << i18n(....)... ?

}

you create a private class to assign to keywordlist in other method.

Use const here

missing copyright

mKeywordList (member variable) => m...

It's better to create private class if we want to keep BC as you install this file.

now that you use private class you can hide addKeyworkList and initKeywordlist into private class

> you clean up method that we can't use in this class

> we clean up header.

Not really necessary as it's initialize by constructor to empty

use:
"
#ifndef LINEEDITWITHKEYWORDS_H
#define LINEEDITWITHKEYWORDS_H

it's better as name