make push/pop part of ConfigModule API
ClosedPublic

Authored by mart on Aug 27 2018, 12:06 PM.

Details

Summary

for better separation, abstract push/pop and columnWidth in the ConfigModule class so
the qml part won't have access to ApplicationItem (which will be eventually
sandboxed anyways)

Test Plan

tested a basic mock kcm with multiple columns

Diff Detail

Repository
R296 KDeclarative
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.Aug 27 2018, 12:06 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 27 2018, 12:06 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
mart requested review of this revision.Aug 27 2018, 12:06 PM
davidedmundson added inline comments.
src/quickaddons/configmodule.cpp
171

good catch, could be the thing Kai was talking about the other day.
Should be a separate commit though

src/quickaddons/configmodule.h
392

I don't understand this sentence. It contains two "when"s

454

hierarchy

mart updated this revision to Diff 40701.Aug 30 2018, 12:34 PM
mart marked an inline comment as done.
  • hopefully clearer comment
mart added inline comments.Aug 30 2018, 12:56 PM
src/quickaddons/configmodule.h
392

hopefully simpler comment

davidedmundson accepted this revision.Oct 8 2018, 10:38 AM
This revision is now accepted and ready to land.Oct 8 2018, 10:38 AM
This revision was automatically updated to reflect the committed changes.