the metadata scanning for the file browser is currently done in the gui
thread. in preparation for moving this to the musiclistenersmanager, keep a
pointer to the trackslistener so that it can be reused
Details
Details
- Reviewers
mgallien - Commits
- R255:1febf6e39c75: keep pointer of track listener
tests pass, music is still scanned correctly
Diff Detail
Diff Detail
- Repository
- R255 Elisa
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
What is your rationale for this change ? I do not agree that we should change things when not needed by some other code changes. Even if there exists some automatic tests, the coverage is not good enough to guarantee that we will not have regressions.
Please see my comments.
| src/musiclistenersmanager.cpp | ||
|---|---|---|
| 123–124 | You should delay the creation until somebody call subscribeForTracks. It is not needed before and will delay the creation of MusicListenersManager. | |
| 202–209 | Keep them in subscribeForTracks. They are not needed when nobody is connected to d->mTracksListener . | |
| src/musiclistenersmanager.cpp | ||
|---|---|---|
| 214–221 | You do not to prepend this-> . | |