Differential D15056

[EnhancedPathShape] Keep correct aspect ratio of shapes in odf files
ClosedPublic
Actions

Authored by anthonyfieroni on Aug 24 2018, 12:57 PM.

Details

Reviewers
danders
boemann
Group Reviewers
Calligra: 3.0
Commits
R8:da40d525d2c0: [EnhancedPathShape] Keep correct aspect ratio of shapes in odf files
Summary

View bound has same aspect ratio as content size, view box is square, so when calculation is applied result rect loose it ratio and always became a square like describe in bug report.

CCBUG: 334608

Test Plan

Now it performed current size bounds to view box, which will result in cutting size to fit view box (if needed) then it scaled to result size by keeping aspect ratio.

Diff Detail

Repository
R8 Calligra
Lint
Lint Skipped
Unit
Unit Tests Skipped
Restricted Application added a project: Calligra: 3.0. · View Herald TranscriptAug 24 2018, 12:57 PM
Restricted Application added a subscriber: Calligra-Devel-list. · View Herald Transcript
anthonyfieroni requested review of this revision.Aug 24 2018, 12:57 PM
anthonyfieroni updated this revision to Diff 40363.

Fix wrong diff

anthonyfieroni retitled this revision from [EnhancedPathShape] Keep correct aspect ratio of odf files to [EnhancedPathShape] Keep correct aspect ratio of shapes in odf files.Aug 24 2018, 1:01 PM
anthonyfieroni edited the test plan for this revision. (Show Details)
anthonyfieroni added a comment.Aug 28 2018, 5:34 AM

Any objections to this?

danders accepted this revision.Aug 28 2018, 7:38 AM

Haven't tested, but sounds sane :)

This revision is now accepted and ready to land.Aug 28 2018, 7:38 AM
Closed by commit R8:da40d525d2c0: [EnhancedPathShape] Keep correct aspect ratio of shapes in odf files (authored by anthonyfieroni). · Explain WhyAug 29 2018, 12:45 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 40363

View Options

plugins/pathshapes/enhancedpath/EnhancedPathShape.cpp

Loading...