Differential D15050

Summary: Using specified FOV's for each planet so the user can zoom. Adding a button to select FOV from the KStars FOV list. Adding another decimal to FOV for small moons.
ClosedPublic
Actions

Authored by lancaster on Aug 24 2018, 5:10 AM.

Details

Reviewers
mutlaqja
Commits
R321:00c6861b9586: Summary: Using specified FOV's for each planet so the user can zoom. Adding a…

Diff Detail

Repository
R321 KStars
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
lancaster created this revision.Aug 24 2018, 5:10 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptAug 24 2018, 5:10 AM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
lancaster requested review of this revision.Aug 24 2018, 5:10 AM
mutlaqja requested changes to this revision.Aug 24 2018, 8:59 AM
mutlaqja added inline comments.
kstars/auxiliary/xplanetimageviewer.cpp
313

"Zoom to a specific FOV. This has no effect when hovering over an object"

1064

for(const FOV *f : KStarsData::Instance()->getAvailableFOVs())

This revision now requires changes to proceed.Aug 24 2018, 8:59 AM
lancaster updated this revision to Diff 40371.Aug 24 2018, 3:02 PM
  • Fixing text

Updating D15050: Summary:

Using specified FOV's for each planet so the user can zoom.
Adding a button to select FOV from the KStars FOV list.
Adding another decimal to FOV for small moons.

lancaster marked 2 inline comments as done.Aug 24 2018, 3:03 PM
mutlaqja added inline comments.Aug 24 2018, 4:48 PM
kstars/auxiliary/xplanetimageviewer.cpp
1063

for, not foreach

lancaster updated this revision to Diff 40378.Aug 24 2018, 7:49 PM
  • Using for not foreach

Updating D15050: Summary:

Using specified FOV's for each planet so the user can zoom.
Adding a button to select FOV from the KStars FOV list.
Adding another decimal to FOV for small moons.

mutlaqja accepted this revision.Aug 25 2018, 7:15 AM
This revision is now accepted and ready to land.Aug 25 2018, 7:15 AM
Closed by commit R321:00c6861b9586: Summary: Using specified FOV's for each planet so the user can zoom. Adding a… (authored by lancaster, committed by mutlaqja). · Explain WhyAug 25 2018, 7:20 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 40402

View Options

kstars/auxiliary/xplanetimageviewer.h

Loading...
View Options

kstars/auxiliary/xplanetimageviewer.cpp

Loading...