kstars/auxiliary/xplanetimageviewer.cpp
313 ↗	(On Diff #40348)	"Zoom to a specific FOV. This has no effect when hovering over an object"
1064 ↗	(On Diff #40348)	for(const FOV *f : KStarsData::Instance()->getAvailableFOVs())

This revision now requires changes to proceed.Aug 24 2018, 8:59 AM

Fixing text

Updating D15050: Summary:

Using specified FOV's for each planet so the user can zoom.
Adding a button to select FOV from the KStars FOV list.
Adding another decimal to FOV for small moons.

Harbormaster completed remote builds in B2200: Diff 40371.Aug 24 2018, 3:02 PM

lancaster marked 2 inline comments as done.Aug 24 2018, 3:03 PM

mutlaqja added inline comments.Aug 24 2018, 4:48 PM

kstars/auxiliary/xplanetimageviewer.cpp
1063	for, not foreach

Using for not foreach

Updating D15050: Summary:

Using specified FOV's for each planet so the user can zoom.
Adding a button to select FOV from the KStars FOV list.
Adding another decimal to FOV for small moons.

Harbormaster completed remote builds in B2205: Diff 40378.Aug 24 2018, 7:49 PM

mutlaqja accepted this revision.Aug 25 2018, 7:15 AM

This revision is now accepted and ready to land.Aug 25 2018, 7:15 AM

Closed by commit R321:00c6861b9586: Summary: Using specified FOV's for each planet so the user can zoom. Adding a… (authored by lancaster, committed by mutlaqja). · Explain WhyAug 25 2018, 7:20 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			kstars/auxiliary/xplanetimageviewer.h (5 lines)
M			kstars/auxiliary/xplanetimageviewer.cpp (83 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	40348	a6510ac		Aug 24 2018, 5:10 AM	★	★
Diff 2	40371	a6510ac	- Fixing text	Aug 24 2018, 3:02 PM	★	★
Diff 3	40378	a6510ac	- Using for not foreach	Aug 24 2018, 7:49 PM	★	★
Diff 4	40402	a6510ac	R321:00c6861b9586eb07c70f2977c9321c7d43065ad1	Aug 25 2018, 7:16 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
08fd14f68ab0	08cfc4cd0690	ec7199e9b701	Robert Lancaster	Fixing text	Aug 24 2018, 3:02 PM
ec7199e9b701	08c363351bc5	a6510ac6766a	Robert Lancaster	Summary: Using specified FOV's for each planet so the user can zoom. Adding a… (Show More…)	Aug 24 2018, 5:07 AM

Summary: Using specified FOV's for each planet so the user can zoom. Adding a button to select FOV from the KStars FOV list. Adding another decimal to FOV for small moons.ClosedPublicActions

Details

Diff Detail

Updating D15050: Summary:

Updating D15050: Summary:

Revision ContentsChangeset List

Diff 40371

kstars/auxiliary/xplanetimageviewer.h

kstars/auxiliary/xplanetimageviewer.cpp

Summary: Using specified FOV's for each planet so the user can zoom. Adding a button to select FOV from the KStars FOV list. Adding another decimal to FOV for small moons.
ClosedPublic
Actions

Revision Contents
Changeset List